Minitest exit with non-zero status if coverage bellow minimum#33
Open
everton wants to merge 1 commit intosocketry:mainfrom
Open
Minitest exit with non-zero status if coverage bellow minimum#33everton wants to merge 1 commit intosocketry:mainfrom
everton wants to merge 1 commit intosocketry:mainfrom
Conversation
…ocketry#32) The minimum coverage can be set with ENV var MINIMUM_COVERAGE (default 100%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #32
The minitest integration was exiting with success even if missing coverage.
Ideally it should exit with an error status, so integration processes can be halted and failures easily detected.
I was not able to find a proper way to specify a minimum coverage, so I used the ENV var MINIMUM_COVERAGE (default 100%).
Types of Changes
Contribution